Assess variables to emit in generated config.gypi

Question

Assess variables to emit in generated config.gypi

Opened this issue 6 years ago · 3 comments

Assess which if any of the config variables are important to include in the js2c'd config.gypi generated by tools/generate_config_gypi.py.

/cc @nornagon

Answer 1 · 2019-02-02T13:09:43.000Z

I implemented a way to generate config.gypi using a Jinja2 template here to fix Node.js tests failures.

Answer 2 · 2019-02-04T18:22:33.000Z

Hm, jinja2 is an odd choice. config.gypi is just a python data structure, so repr() should be sufficient, no?

Answer 3 · 2019-02-04T22:04:37.000Z

I'm not a python guy. I just took it because we have it in DEPS anyways. I found replacing stuff in a template easier to read than programmatically altering an object like Node.js' configure script does.