Configure - "if options.run_gyp:" should be "if not options.run_gyp"
Opened this issue · 0 comments
tmcdos commented
I am using Windows on my PC and I have an unrelated issue with the bundled Node so I have to patch one of the Node's internal JS modules (and hence must recompile node.dll
)
When I tried to build electron-node-10.2.0
I got the error Failed to create vc project files.
After some primitive debugging I think that the reason for this error lies on the last line in configure
. Instead of
if options.run_gyp:
run_gyp(gyp_args)
it should be
if not options.run_gyp:
run_gyp(gyp_args)