electron/rcedit

Inno-setup generated installation file was broken after modify version string by rcedit

cuixiping opened this issue · 5 comments

cuixiping commented

I use inno-setup to generate installation file and then modify some information by rcedit.
The file size will be reduced to about 100~200KB and cannot work correctly.

zcbenz commented

Can you provide an example exe file so we can look into the problem? And can you check whether it is the same bug with the other issues?

  • 👍1
sommcz commented

Hello, i have similiar problem.

  • I generate uninstaller.exe with NSIS with ExectuionLevel user (very simple installer from tutorial: http://nsis.sourceforge.net/Simple_tutorials)
  • and change execution level with rcedit: rcedit.exe uninstaller.exe --set-requested-execution-level requireAdministrator
  • after that uninstaller elevate (OK)
  • but file looks corruped (BAD)

Probably some NSIS's CRC?
(I already tried remove CRCcheck with /NCRC or CheckCRC off options)

image

pack.zip

On my real installation uninstaller changed size from 188kB to 60kB after rcedit and removed all file version info.

  • 👍1
sommcz commented

additional info:
It looks like some installer data were being stripped out by the rcedit

image

If i do the same change manually with http://www.angusj.com/resourcehacker, it works OK.

If i use rcedit before adding end-of-file data, it works ok too (http://nsis.sourceforge.net/Using_!packhdr).

vasanthaganeshk commented

I can confirm that I have the same issue.

thomasrea0113 commented

I am having the same issue with Inno Setup 5.x after changing ProductName and CompanyName

image