Updating node-abi dependency to make electron-rebuild work with electron 15.x properly
tom2strobl opened this issue · 8 comments
As of right now, electron-rebuild builds for a wrong node version for me
Error: The module 'app/node_modules/better-sqlite3/build/Release/better_sqlite3.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 89. This version of Node.js requires
NODE_MODULE_VERSION 98. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).
because https://github.com/electron/electron-rebuild/blob/master/src/rebuild.ts#L124 gets the abi number from node-abi 3.0.0, whereas 3.2.0 has support for electron 15.x
Workaround for me right now is to add
"resolutions": { "**/node-abi": "^3.2.0" }
to the package.json, which is working and proves the case, but is dirty long-term.
We stumbled on this when trying to upgrade to Electron 15.
Looks like it should already be fixed in master via #861, but not released yet - the latest release 3.2.3 still depends on node-abi@^2.19.2.
Would you consider publishing a new release that includes this fix? Thanks a lot! 🙂
Correction: This appears to have happened already, here: #876. Just waiting on a release! 🤞🏼
Nudge. Are there plans for a new release?
Im wating to new release.
v3.2.5 still throwing the same error.