elek/cethacea

Bool type support in function signature encoding

Closed this issue · 4 comments

humayunj commented

Thanks for this incredibly sharp swiss-army knife. I wonder if it's still being maintained. Straight to the issue.

The function arguments encoding doesn't support bool types. As we can see in EncodeArguments function.

As the result ceth exits with unsupported argument type { bool false}. Case for tuple is not implemented either but I haven't dig into it.

Example

Command: ceth contract call --debug --account=key1 "setApprovalForAll(address,bool)" $operator false // or 0/0x00

Output: Error: unsupported argument type { () false}

elek commented

I wonder if it's still being maintained

Well, I use it, but usually I implement only what I directly need ;-)

But bool support is easy. Just added it in 46f14da.

Thanks for the report.

humayunj commented

That was quick! I actually found the tool from your Storj blogs, and used cethacea though whole process of deploying and debugging (tx debug) while implementing ERC-721 in Yul. Great work!

elek commented

Great. Thanks to share. Good to know.

We (storj) also uses it for some integration tests and development (for example in https://github.com/storj/storjscan). So it should definitely work in the future.

I just started to use cethacea for transferring real money (ETH/ tokens) from command line. That's the reason why I added the confirmation option (and the gas calculation also should be fixed. Earlier I used a very high number which doesn't fly on real servers)...

humayunj commented

Superb.