Unable to use with Magento 2.4.4 (latest)
Closed this issue · 10 comments
magento/magento2-base 2.4.4 requires symfony/console ~4.4.0
You could always use the binary in the meantime :)
Good point, I hadn't considered not installing with composer 👍
@peterjaap looks like it works, but there are a number of PHP 8.1 deprecated errors, like:
PHP Deprecated: Return type of HumbugBox3100\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///workspace/project/masquerade.phar/.box/src/RequirementCollection.php on line 15
etc, etc
Is that expected?
Oh yes I didn't make it compatible with PHP 8.1 yet. We run Masquerade in an isolated Gitlab runner which runs on PHP 7.4 even though our Magento projects run on 8.1 No issue there.
Apparently Box needs to updated, so it includes this MR box-project/box#587
@davidwindell could you test this build?
@peterjaap thanks, that removes some of the errors, I've just tested the identify command and get:
Deprecated: preg_replace(): Passing null to parameter #2 ($replacement) of type array|string is deprecated in phar:///workspace/project/masquerade.phar/src/Elgentos/Masquerade/Console/IdentifyCommand.php on line 296
PHP Deprecated: preg_replace(): Passing null to parameter #2 ($replacement) of type array|string is deprecated in phar:///workspace/project/masquerade.phar/src/Elgentos/Masquerade/Console/IdentifyCommand.php on line 296****
@davidwindell and this one?
@peterjaap that seems pretty good to me, I've only tested the identify command but there aren't any errors on that one now 🥇
Thanks for testing @davidwindell , I've issued a new release https://github.com/elgentos/masquerade/releases/tag/1.2.0