Question about the label range.
Closed this issue · 1 comments
jingyang2017 commented
Hi, Elijah!
Great work! After reading the source code, I have a question about the observed label's range in losses.py.
From my understanding, "label_vec_obs" is in {-1,1} and "label_vec_true" is in {0,1}.
But for losses 'bce' and 'bce_ls' , 'train_set_variant' is set as 'clean' and their label_vec _obs is same as label_vec_true.
However, in 'losses.py' ,
line 35, 48, assert not torch.any(observed_labels == 0),
line 134 assert torch.min(observed_labels) >= 0
Did I miss anything in observed label generating?
elijahcole commented
Good catch! You're absolutely right, it looks like that's a bug which crept in during refactoring. I just pushed a fix.