elixir-lang/elixir

Bad contrast on ExUnit output

Closed this issue · 1 comments

Elixir and Erlang/OTP versions

elixir --version

Erlang/OTP 28 [erts-16.1] [source] [64-bit] [smp:12:12] [ds:12:12:10] [async-threads:1] [jit]

Elixir 1.18.4 (compiled with Erlang/OTP 28)

I have this minimal script to test:

ExUnit.start()

defmodule FailingTest do
  use ExUnit.Case

  test "this test will fail" do
    assert false
  end
end

ExUnit.run()

If I run this on Ghostty default color scheme is hard to see the file name where the fail happened (pointed by red arrow):

Image

On iterm2 with the dark background theme it is completely invisible:

Image

And this happens to most dark themes, like One Half Dark on Ghostty:

Image

for it to be visible I need to change the ANSI Color#1 or the background, because in many many dark themes that I checked both colors are equal or very close to each other.

So maybe we should use a different color for this?

Operating system

MacOS TahoeTahoe

Current behavior

The filename where the test has failed has a color hard to distinguish from the background, make it invisible

Expected behavior

I'd like for the color to have more contrast with the background.

It is very hard for us to guarantee it will work on all color schemas. The general consensus is that bright/black shows up as a gray (wikipedia also says as much), but we can't control if some themes treat it as dark. You can however customize the CLI colors and pick something that works better for you. You may also consider reporting those as bugs upstreams and see what they say. Thank you!