Switch to use the new `with` syntax
mmmries opened this issue · 2 comments
We currently use the pipe library to do pattern matching and early exit in the query module.
As of elixir 1.2.0 this will have language-level support using the new with syntax. What timeline should we be thinking about for dropping the pipe dependency and using the new with syntax? Should we just keep pipe until we hit the 1.0 version and then switch to using with and change our project definition to require elixir 1.2.0+?
It looks like Ecto is moving to Elixir 1.2 as a dependency once Ecto 2.0 comes out in a month or two. When that happens, I will be updating Sqlite.Ecto to rely on Elixir 1.2 as well. Any time after that is fine from my perspective unless there are other projects relying on Sqlitex.
@jazzyb thanks for weighing in. Sqlite.Ecto was definitely my main concern. Because this project doesn't have a lot of churn I would even consider maintaining a stable branch aimed at the Elixir 1.0.0 series in parallel with a stable branch aimed at 1.2.0. I'm not sure if it would be useful to anyone so I'll probably just watch for the Ecto 2.0 drop and make the change at that time along with a major version bump to 1.0.0