elixir-sqlite/sqlitex

Have Sqlitex.open/1 take a String

jazzyb opened this issue · 1 comments

Right now, opening a database is a special case in that we pass a char list in for the path argument. All other functions take Strings. Would it make sense to either (1) have open/1 exclusively accept Strings for path args, or (2) have open/1 accept both char lists and Strings? Thoughts?

I think the least surprising thing we could do would be to make open/1 accept a binary (String) as well as accepting a charlist. The charlist will be easier for anyone moving from esqlite to this library and taking a binary makes it less surprising to people familiar with elixir.