ellipsis/ellipsis

purpose of ELLIPSIS_REPO

Opened this issue · 1 comments

r4lv commented

Dear all,

I noticed some (minor) inconsistencies in how $ELLIPSIS_REPO is defined:

ellipsis/scripts/install.bash

Line 18 in 63846f1

url="${ELLIPSIS_REPO:-$proto://github.com/ellipsis/ellipsis.git}"

and

ellipsis/src/init.bash

Line 21 in 63846f1

ELLIPSIS_REPO="${ELLIPSIS_REPO:-https://github.com/$ELLIPSIS_USER/ellipsis}"

From what I see, $ELLIPSIS_REPO is only used when installing via curl ellipsis.sh | bash, and in the test suite.

  1. Not sure how many people actually use their own fork of ellipsis itself, but wouldn't it make sense to add $ELLIPSIS_USER to the line in install.bash? And, the other way round, add $ELLIPSIS_PROTO to the definition in src/init.bash?
  2. Why is $ELLIPSIS_REPO defined in src/init.bash? From what I see, when installing ellipsis, the order of execution is
    1. (scripts/shim.sh)
    2. scripts/install.bash
    3. define $url based on $ELLIPSIS_REPO (see above)
    4. clone $url
    5. source src/init.bash
    6. define $ELLIPSIS_REPO. At that point it is never used any more.

Or did I miss something?

Looking forward to hearing from you!

groggemans commented

Awesome that you took the time to dive into the code!

I think you are correct, and $ELLIPSIS_REPO does not seem to be used/needed after the init.bash file is loaded. Probably a remnant from the past. (So I guess it's safe to just remove it there)
Could be that someone actually used ellipsis/ellipsis to then bootstrap username/ellipsis but I think it's safe to ignore this edge case.

In the installer the username is not replaced as that would result in the installer defaulting to a custom repo url, while 99% of the users actually use ellipsis/ellipsis. So for me it makes most sense not to have the username included in the url there.