`DiffAdd` is grey

[ambroisie]

Describe the bug
After updating the plug-in, the color of DiffAdd changed from green to grey.

To Reproduce
Steps to reproduce the behavior:

1. Use git commit with commit.verbose=true configured.
2. Notice that the wrong color is being used.

Expected behavior
I would expect it to be green, as it used to be.

Screenshots

Additional context
I'm not sure why it changed, as looking at the code/:highlight everything looks in order. I don't override any color in my config either.

[ambroisie]

This is in the terminal with termguicolors enabled.

[ambroisie]

This seems to be related to tmux, as running nvim outside of tmux shows the correct colors (though more muted than I rembered).

[ambroisie]

Here is how it looked before:

In tmux:

Outside of tmux:

This is with tmux 3.3a in all screenshots.

[ambroisie]

The change in look seems to be from d3b86c2 and related to #239. I will be looking into how to reverse the change, as I dislike the more muted look.

I will leave the bug open, as I think this might be an issue for other people, even if I work around it through going back to the previous style.

[mrvon]

Agree, Old style more confortable and clear to me, I use tag to revert it right now.

Plug 'ellisonleao/gruvbox.nvim', {'tag': '5e697fa640944dd4a98748d15c6e0a7725777551'}

[ambroisie]

Alright, so I fixed the tmux/native terminal issue: turns out my tmux was not correctly configured for 24-bit colour!

See this SO answer.

I still dislike the new styling however, so thankfully #291 gets us most of the way there (not quite: I want both the old colours and the low-key high-lighting from reverse = true).

[ellisonleao]

hey guys, thanks for opening the issue. I've made a comment in the PR so i really think this should be changed using overrides in your config. LMK if that work for you guys

[ambroisie]

@ellisonleao I opened a discussion about an issue I have with overrides: #321.