GitSigns use wrong background color

Describe the bug
I'm not sure if this is intentional or not, but to me it seems like GitSignsAdd etc. use the wrong background color because they link to GruvboxGreen etc.

gruvbox.nvim/lua/gruvbox.lua

Lines 400 to 402 in 0940564

    
           GitSignsAdd = { link = "GruvboxGreen" }, 
        
           GitSignsChange = { link = "GruvboxAqua" }, 
        
           GitSignsDelete = { link = "GruvboxRed" },

It looks as expected if I use GruvboxGreenSign etc. instead (with the default settings and transparent_mode = false).

As a workaround, I use this configuration in lazy:

  {
    'ellisonleao/gruvbox.nvim',
    enabled = true,
    event = 'VeryLazy',
    keys = { '<F54>', '<Cmd>colorscheme gruvbox', desc = 'Gruvbox (colorscheme)' },
    priority = 1000,     -- load before the other start plugins
    opts = {
      contrast = 'soft', -- 'hard', '', 'soft'
      dim_inactive = true,
      overrides = {
        NormalFloat = { bg = '#32302f' }, -- FIXME: make floating windows discernible when dim_inactive
        GitSignsAdd = { link = "GruvboxGreenSign" },
        GitSignsChange = { link = "GruvboxOrangeSign" },
        GitSignsDelete = { link = "GruvboxRedSign" },
      },
    },
  }

These changes were introduced in 9fb8fce and I think this was intentional.

I'm currently using this override in my config to make it look better:

SignColumn = { link = "LineNr" }

These changes were introduced in 9fb8fce and I think this was intentional.

Thanks, that makes sense. I'll close this issue assuming that it's indeed intentional (it's easy enough to work around using overrides).

Please don't close it, using overrides is not a solution.

If you read the comment in the linked commit, @ellisonleao said:

But answering your question, the main point of the change was to remove the BG of that highlight which is the way other colors themes are using it

So it does seem like an intentional choice. I'll leave it to @ellisonleao to re-open the issue if he considers it to be a bug.

	GitSignsAdd = { link = "GruvboxGreen" },
	GitSignsChange = { link = "GruvboxAqua" },
	GitSignsDelete = { link = "GruvboxRed" },