[Android Bootcamp] Grid Search Review
Opened this issue · 1 comments
ellisw commented
I'm done. Please review. Learned a lot of new concepts in this one. Thanks!
Ellis Weng
/cc @nesquena @timothy1ee
nesquena commented
Ellis, 👍 nice work. A few notes after checking out the code:
- Consider cleaning up spinners by populating entries in the view instead.
- Consider using
totalItemsCount
here for endless scroll pagination - Nice use of
GoogleSettings
to encapsulate complexity and pull it out of the controller - Nice job passing filters around using the serialized object
Also, here's provided a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.