els0r/goProbe

Extend testing (using mock capture sources)

Closed this issue · 2 comments

fako1024 commented

Depends on fako1024/slimcap#7 , in which a way of mocking a fully functional capture source is provided.

DoD

  • Replace existing mock logic implemented in #80 (once the referenced changes are merged)
  • Extend tests leveraging the new functionality
  • Add E2E test
fako1024 commented

The good news is that I got a full-blown E2E test to work, including goProbe / goQuery round-trip. The bad news is that the tests did reveal a race condition in the ring buffer mock source which will require some fixing. Since I'll be afk next week I'll probably have to continue after that. @els0r FYI.

els0r commented

The good news is that I got a full-blown E2E test to work, including goProbe / goQuery round-trip. The bad news is that the tests did reveal a race condition in the ring buffer mock source which will require some fixing. Since I'll be afk next week I'll probably have to continue after that. @els0r FYI.

I would call that double good news if more rigorous testing reveals previously unknown flaws.

Thanks for letting me know. I'll chip away at #43 in the meantime.

Cheers from Portland