elvetemedve/behat-screenshot

Symfony 5 support

mnocon opened this issue · 3 comments

mnocon commented

Hi!

This is a great Behat extension, but currently it does not support Symfony 5 - are there plans to add support for it?

The current composer.json contains:

        "symfony/filesystem": "^2.7|^3.0|^4.0",
        "symfony/finder": "^2.7|^3.0|^4.0"
        "behat/mink-extension": "^2.0.0",

which are not Symfony 5 compatible - would you be interesed in a PR that bumps these dependencies/upgrades code if needed?

I know that the Behat MinkExtension does not support Symfony 5, but there is a fork for that: https://github.com/FriendsOfBehat/MinkExtension which can be used.

elvetemedve commented

Hi @mnocon!

There is no plan currently. Mainly because writing UI tests with Behat for large projects have been found to be not good idea. Instead it's better to use Behat for domain tests/specifications only and do UI tests by other tools which are invented for that purpose. But I believe smaller projects or other special domain still can benefit from this extension.

So I would say it's worth giving a try. If it does not require too much refactoring, Symfony 5 support would make sense.

mnocon commented

I've got it working locally with these two PRs:
#51
tkotosz/behat-extension-driver-locator#1

Out of curiosity, as we're using Behat/Mink for browser testing currently - which tool have you decided to use instead?

elvetemedve commented

Current choice is a proprietary tool called Ghost Inspector.

  • 👍1