Handle review comments from DRF
Closed this issue · 7 comments
There's a few review comments on the DRF PR that never got marked as completed. For example, support for async fields on serializers.
Mark them as completed over there if needed, or create issues on this repo to handle those tasks.
I would like to add async support to serializers and mixins. Is there anything else?
- encode/django-rest-framework#8617 (comment)
- encode/django-rest-framework#8617 (comment)
- encode/django-rest-framework#8617 (comment)
- The comment above encompasses the following....
- https://github.com/encode/django-rest-framework/issues/8655
- https://github.com/encode/django-rest-framework/issues/8656
- https://github.com/encode/django-rest-framework/issues/8657
@Archmonger Thanks a lot for the comment. The exceptions in the Django admin and when clicking the OPTIONS button are fixed already. The only problem left is making an async version of the serializer since the one in DRF needs to be wrapped with sync_to_async for it to work.
Hey, @em1208 is there any update on adding async support for serializers?
Looks like the answer is nope. But, it should be a fairly simple contribution.
@DhruvaPatil98 Would you be willing to PR this?
Looks like the answer is nope. But, it should be a fairly simple contribution.
@DhruvaPatil98 Would you be willing to PR this?
I'm afraid I don't have the bandwidth at the moment to look into this.