emacs-lsp/helm-lsp

helm-lsp no longer works with melpa-stable lsp-mode 6.3.1

laurynas-biveinis opened this issue · 4 comments

After the latest melpa update, loading helm-lsp fails with

Debugger entered--Lisp error: (void-function lsp-defun)
  (lsp-defun helm-lsp-workspace-symbol-action ((&SymbolInformation :location (&Location :uri :range (&RangeToPoint :start)))) "Action for helm workspace symbol.\nCANDIDATE is the selected item in the helm menu." (find-file (lsp--uri-to-path uri)) (goto-char start))
  eval-buffer(#<buffer  *load*-841817> nil "/Users/laurynas/emacs/elpa/helm-lsp-20200608.1949/helm-lsp.el" nil t)  ; Reading at buffer position 1757
  load-with-code-conversion("/Users/laurynas/emacs/elpa/helm-lsp-20200608.1949/helm-lsp.el" "/Users/laurynas/emacs/elpa/helm-lsp-20200608.1949/helm-lsp.el" nil t)
  require(helm-lsp)
  eval-buffer(#<buffer  *load*-368019> nil "/Users/laurynas/emacs/setup.el" nil t)  ; Reading at buffer position 43793
  load-with-code-conversion("/Users/laurynas/emacs/setup.el" "/Users/laurynas/emacs/setup.el" nil nil)
  load("/Users/laurynas/emacs/setup")
  eval-buffer(#<buffer  *load*> nil "/Users/laurynas/.emacs" nil t)  ; Reading at buffer position 1439
  load-with-code-conversion("/Users/laurynas/.emacs" "/Users/laurynas/.emacs" t t)
  load("~/.emacs" t t)
  #f(compiled-function () #<bytecode 0x400d1a6d>)()
  command-line()
  normal-top-level()

Package-Requires for helm-lsp lists lsp-mode 5.0, might be outdated?

;; Package-Requires: ((emacs "25.1") (dash "2.14.1") (lsp-mode "5.0") (helm "2.0"))

you need the latest lsp-mode which has that macro.

@yyoncho perhaps you have considered making a melpa-stable release of helm-lsp that would be compatible with melpa-stable lsp-mode?

Tagged https://github.com/emacs-lsp/helm-lsp/releases/tag/0.1 (which does not contain the latest commit).

Let me know if you run into an issue.

Works great; thanks!