emailjs/emailjs-tcp-socket

State of Cordova support; Why are we still using forge?

RedHatter opened this issue · 2 comments

I'm using emailjs on Cordova using the cordova-plugin-chrome-apps-sockets-tcp plugin. By default emailjs is still using forge with Cordova, but after editing the code below to use native TLS everything still works great. Is the fix no longer needed?

chrome.runtime.getPlatformInfo(function(platformInfo) {

    //
    // FIX START
    //

    if (platformInfo.os.indexOf("cordova") !== -1) {
        // chrome.sockets.tcp.secure is not functional on cordova
        // https://github.com/MobileChromeApps/mobile-chrome-apps/issues/269
        self._useLegacySocket = false;
        self._useForgeTls = false;
    } else {
        self._useLegacySocket = true;
        self._useForgeTls = false;
    }

    //
    // FIX END
    //

    // fire up the socket
    if (self._useLegacySocket) {
        self._createLegacySocket();
    } else {
        self._createSocket();
    }
});

Did you connect with STARTTLS as well? This pull request #27 fixed STARTTLS in Desktop Chrome Apps, did it also fix Cordova?

I'm going to close this as chrome apps are going away and support for chrome apps will be removed going forward.

see: emailjs/emailjs-imap-client#158