Bug: Repeating transaction record is added on each page update

After adding a repeating transaction with a one week period, I have one record added on each reload of the main page. The records just accumulate indefinitely. However, if the repeating period is one day, then the bug does not reproduce.
I would guess that the bug is on the following line:

oinkoin/lib/services/recurrent-record-service.dart

Line 47 in 54e293b

    
           int numberOfWeeks = (difference(endDate, startDateTrimmed).abs().inDays / 7).floor();

Should we use lastUpdate time instead of startTime (similarly to the each day pattern)?
I am not familiar with the codebase, so it is just a guess.

Version: com.github.emavgl.piggybankpro-1.0.34
(Installed from f-droid)

Screenshot:

Hello, thank you so much for reporting the bug and thanks for looking also at the code spotting the bug.

I think that line is the problem, unfortunately I am in vacation at the moment and don't have access to the PC.

I'll fix as soon as possible, in the next few days. Sorry for the inconvenience

As a note. From the code it seems also bi-weekly recurrent transactions have the same problem.

Hi there,

I have changed the lines and tested locally, it should be good by now, but if you could test it would be better.

The changes is in commit: 0920cd8
There is already a new release with the change: https://github.com/emavgl/oinkoin/releases/tag/1.0.35

Hi there,

I have changed the lines and tested locally, it should be good by now, but if you could test it would be better.

The changes is in commit: 0920cd8 There is already a new release with the change: https://github.com/emavgl/oinkoin/releases/tag/1.0.35

Hello,
The changes look good. I tested the new release, the bug didn’t reproduce. Thank you!

Perfect, thanks for trying and again for reporting.

I am closing the issue