embeddedt/VintageFix

Binnie's Extra Trees broken particles fix doesn't work with VintageFix

Closed this issue · 3 comments

xJon commented

ACGaming/UniversalTweaks#447

Referring to: Lumbermill, Woodworker, Panelworker, Fruit Press, Brewery, Distillery, Glassworker
Does not affect the Forestry broken particles fix though (e.g. Arborist's Chest).

https://github.com/ACGaming/UniversalTweaks/blob/01edaae6a4c41af41a8f2e19c834bc53a88f42c1/src/main/java/mod/acgaming/universaltweaks/mods/forestry/extratrees/UTExtraTreesParticlesFixer.java#L24-L30

For compatibility with dynamic resources, this loop needs to iterate over the blockstates for the machine block and get their model resource locations manually, rather than iterating the model registry and filtering for matching locations. It's very annoying/difficult to emulate the full set of model keys on my end.

If it's absolutely necessary to make it work from my end I can try, but I think my proposed fix should be easy enough.

xJon commented

@embeddedt I appreciate it, although it's already figured out, as a direct patch to Binnie's (ACGaming/Binnie#5) ended up being a good & compatible solution.