Only last argument logged after benchmark fails or times out
sobuch opened this issue · 0 comments
sobuch commented
Code starting at https://github.com/embench/embench-iot/blob/master/benchmark_speed.py#L204:
if succeeded:
return exec_time
else:
for arg in arglist:
if arg == arglist[0]:
comm = arg
elif arg == '-ex':
comm = ' ' + arg
else:
comm = " '" + arg + "'"
log.debug('Args to subprocess:')
log.debug(f'{comm}')
This results in logging only last argument passed to subprocess instead of all of them. I suppose it was intended to be like this (only difference is usage of '+='):
if succeeded:
return exec_time
else:
for arg in arglist:
if arg == arglist[0]:
comm = arg
elif arg == '-ex':
comm += ' ' + arg
else:
comm += " '" + arg + "'"
log.debug('Args to subprocess:')
log.debug(f'{comm}')