ember-best-practices/ember-perf-timeline

Add configurations to enable perf-timeline in development without queryParams

kanalveli-ramachandran opened this issue · 3 comments

kanalveli-ramachandran commented

During development, adding the _ember-perf-timeline queryParam to every route we profile is a bit cumbersome. It will be useful to add a configuration to always enable component measures in development environment.

I'd like to contribute towards this if it sounds good.

Deleted user commented

Totally agree. I also could not dynamically specify the _ember-perf-timeline query parameter when invoking transitionTo methods. Probably because I didn't configure the routes 😄

This relates somewhat to #19. Perhaps a configuration / some design could cover both?

danDanV1 commented

@xg-wangs config would be helpful here. I am working on profiling route transitions with animations, and ember will drop the _ember-perf-timeline query param from the URL on the transition unless I sprinkle it into all our controllers.

xg-wang commented

@edeis53 the added section in readme in the merged PR has configuration https://github.com/ember-best-practices/ember-perf-timeline/pull/31/files#diff-04c6e90faac2675aa89e2176d2eec7d8
And I think transition dropping QP wouldn't matter because the setup by reading QP is done only once in initializer.