How to solve tabindex etc deprecations?

Question

How to solve tabindex etc deprecations?

RobbieTheWagner opened this issue 5 years ago · 11 comments

Now that ember-bootstrap has deprecated <el.control @tabindex="1"> in favor of passing the raw HTML attribute tabindex, deprecations are thrown when using this addon. It does not seem to be possible to remove the @ because the arg needs to be passed into power-select. Any advice on getting around these deprecations? Will this addon be updated to support the same syntax as ember-bootstrap?

Answer 1 · 2020-02-13T20:36:43.000Z

Are you using the latest release (2.0) of this addon? #89 applies ...attributes to the power-select component, so if power-select itself applies the attributes correctly, I would expect it to work!?

Answer 2 · 2020-02-13T20:39:22.000Z

@simonihmig power select does not apply the attributes though, is what I suppose I am getting at. They have to be passed as arguments for power select to apply them.

Answer 3 · 2020-02-13T20:52:46.000Z

There is an ...attributes in power select, but I don't think it does what we think https://github.com/cibernox/ember-power-select/blob/v3.0.6/addon/templates/components/power-select.hbs#L16

tabindex has a separate value set here https://github.com/cibernox/ember-power-select/blob/v3.0.6/addon/templates/components/power-select.hbs#L32

And the same with disabled https://github.com/cibernox/ember-power-select/blob/v3.0.6/addon/templates/components/power-select.hbs#L12

I think we are going to have to allow @ for attributes when the controlType is power-select or they are not going to be applied.

cc @jelhan

Answer 4 · 2020-02-13T21:18:06.000Z

@rwwagner90 are you sure that <el.control @tabindex="1"> does trigger a deprecation?

<form.element @type="power-select" @tabindex="1"> should, but IIRC the yielded el.control should actually not (for internal reasons).

Answer 5 · 2020-02-13T23:45:20.000Z

Haven't considered that some plugins may need that arguments to be honest. But at least for Power Select that is hopefully fixed upstream soon. The limitation is tracked in this issue cibernox/ember-power-select#1203 and a pull request is provided in cibernox/ember-power-select#1331. I would ignore the deprecation until that landed.

@simonihmig I think we should make sure that using HTML attributes is supported by Power Select before releasing v4.

Edit: Added a chapter to track that potential release blockers in the roadmap issue (ember-bootstrap/ember-bootstrap#957).

Answer 6 · 2020-02-14T06:36:35.000Z

same issue with @placeholder

Answer 7 · 2020-02-14T13:27:11.000Z

@jelhan I think my recommendation would be to update this addon to pass through the attributes as if they were arguments. Then we could enforce passing them as attributes to this addon, and it would change them back to args. So internally you would, I think, have to do something like this to pass to power-select:

@placeholder={{attributes.placeholder}}

I'm not totally sure if you can access attributes like that or not though.

Answer 8 · 2020-02-14T13:35:55.000Z

As far as I know the attributes passed in with angle bracket invocation couldn't be accessed from within a component.

Answer 9 · 2020-02-14T13:54:36.000Z

@jelhan so ..attributes is the only way to use them? If so, we probably need to make this addon not require everything to be attributes.

Answer 10 · 2020-02-14T14:02:31.000Z

@jelhan so ..attributes is the only way to use them? If so, we probably need to make this addon not require everything to be attributes.

As far as I'm aware: yes.

Answer 11 · 2022-07-19T10:10:05.000Z

I think this has been fixed upstream. Please let me know if it is still an issue.