Don't work as dependencies
villander opened this issue · 4 comments
ember-fecth does not work in my consumer app with Fastboot enabled, when I put ember-fetch as dependencies in my addon
cosumer app - https://github.com/villander/ember-mvp
addon - https://github.com/villander/ember-apollo-client/blob/apollo-client-2.0/package.json#L34
looks like ember-fetch specifically doesn’t work with fastboot when it’s a nested dependency
because its updateFastBootManifest() method is never called
the question is what happens when you wind up calling that hook multiple times?
like if ember-mvp and ember-apollo-client both have ember-fetch installed, does it get called twice?
is it ember-fetch’s responsibility to guard against that?
@kratiahuja got any cycles?
@kratiahuja can you help us with that? or some hint of how to solve it, I can work on it if I know the cause
I opened up ember-fastboot/ember-cli-fastboot#597 to try and start driving toward a solution here. @stefanpenner @kratiahuja would love to get your thoughts