ember-learn/deprecation-app

Fix deploy preview build failures

Closed this issue ยท 5 comments

  • we're consistently seeing a failure on netlify deploy preview builds around NAJAX deprecation
  • I had thought that updating to Ember Data 3.22 would fix this, but that doesn't appear to be the case
  • need to investigate possible causes of this issue and potentially contact Ember Data team

@jaredgalanis Could it be related to this issue mentioned on Discord?
If so, I can confirm that removing the node_modules folder fixes it. Hope it helps.

@bertdeblock Let's check if the issue is ongoing when you open a pull request for #715?

To my recollection, after updating Ember Data to a recent version, we might have fixed this issue by clearing the cache and restarting the build in Netlify (to my understanding, this clears node_modules in effect).

@bertdeblock @ijlee2 I investigated this a number of weeks back and it appears that the build cache is not being cleared on the build image. I don't know if blowing away node_modules will change that, but it might.

I "fixed" this by changing which build image is being used in Netlify (from xenial --> trusty). So you should not see the errors in your PR builds. I still plan on going back and trying to clear the cache on the xenial image manually (and I'll give your suggestion a try @bertdeblock), but for now it functions okay.

Going to leave this issue open for now until I do that.

Yeah, we've also ran into the same issue (where I work) when running tests in CI. Clearing the cache solved it for us ๐Ÿ‘

@bertdeblock you were correct, blowing away node_modules definitely solved the issue. Thank you!

Closed by #693 and #730