ember-learn/ember-api-docs

Update components to extend glimmer/component and enable ember/no-classic-components rule

geneukum opened this issue · 0 comments

geneukum commented

Right now, there are a bunch of classic components in ember-api-docs. It would be nice to work through those and upgrade them all to use native syntax and extend from glimmer/component. The components requiring modifications are:

  • app/components/api-index-filter.js
  • app/components/api-index.js
  • app/components/class-field-description.js
  • app/components/import-example.js
  • app/components/loading-spinner.js
  • app/components/search-input.js
  • app/components/search-input/dropdown-header.js
  • app/components/search-input/dropdown-result.js
  • app/components/search-input/dropdown.js
  • app/components/table-of-contents.js

Once we've done this we should then:

  • re-enable the ESLint rule: 'ember/no-classic-components'

to prevent us from accidentally adding any legacy style components going forward.