ember-learn/ember-api-docs

Make the codeblocks work for the website redesign

mansona opened this issue · 2 comments

mansona commented

Example page where it's not working: https://ember-api-do-website-re-9n6ekm.herokuapp.com/ember/release/classes/Application

Notes on the current implementation

  • The codeblocks come to us as HTML from the bucket
  • The ember-jsonapi-docs repo (the thing that converts the yuidoc to jsonapi) has a function in lib/markup.js that finds codeblocks and manually makes them like this.

Todo

  • get a sample of the input format that is passed to the lib/markup.js function to see what format it is
  • figure out if there is a possibility to consider the description key on the json-api response as markdown and use ember-showdown-prism to do the highlighting work
MinThaMie commented

This will be fixed upstream by the work @jaredgalanis and @mansona are doing #902