`setupRouter` deprecation warning
Closed this issue · 3 comments
The browser console shows the following warning on the latest version:
DEPRECATION: The use of Ember.Router in setupRouter is deprecated. Please use the router service. [deprecation id: ember-app-scheduler.setupRouter]
Updating to ember-router-scroll v4 should fix that.
@Windvis would you be interested in submitting a PR with the fix? I think it's not as simple as changing the dependency version.
Yea, it seems the router no longer needs to be extended. So in theory the AddonDocsRouter is no longer needed either.
Should I show a warning message that extending AddonDocsRouter is no longer required (and update the docs accordingly)? Or should it be kept in case it's needed in the future?
I think we may still need AddonDocsRouter. It just would not need to extend EmberRouterScroll anymore potentially.