emberjs/ember-inflector

"octopi" is incorrect

lolmaus opened this issue · 7 comments

The -us -i forms come from Latin.

The word octopus is of Greek origin. It's Greek plural form is octopodes, but in English the word is commonly pluralized according to English rules: octopuses.

Since so many people fall for this error, some dictionaries mark octopi as a possible pluralization. Nevertheless, we should not support this common mistake.

Both the logic and the readme need to be fixed.

Prooflinks:

This library aims to be compatible with ruby’s Active-support. So if they have this, we can also change.

Then I suspect we should leave it as is.

That being said, I’m totally not apposed to a secondary language pack / config option, that has a more actively maintained language list

the library was Built with this in mind.

On the other hand, it has this.

@lolmaus I just check, it does support octopus -> octopi:

gem install activesupport
irb
irb(main):008:0> require 'active_support/all'
=> true
irb(main):009:0> 'octopus'.pluralize
=> "octopi"

We will totally accept a PR to correct this.

@lolmaus Thanks for taking the time to care about the little details like this! From one fellow grammar nerd to another, much appreciated <3