emberjs/ember-test-helpers

`scrollTo` target type inconsistent with other test helpers

nwhittaker opened this issue · 0 comments

The scrollTo helper accepts a target of type string | HTMLElement. Most other helpers accept a target of string | Element. By requiring an HTMLElement, the API is inconsistent and introduces type friction between test helpers:

const container = find('div');

scrollTo(container, , )  // Argument of type 'Element' is not assignable to parameter of type 'string | HTMLElement'.

Any problems or objections to having scrollTo require a string | Element instead?