Glint does not support gts imports with the extension
NullVoxPopuli opened this issue · 6 comments
NullVoxPopuli commented
This is more a tracking issue, as I think Glint would need to solve this.
But I have a repro here: universal-ember/ember-primitives#114
error looks like this:
[js] created dist in 738ms
[js] npm run build:js exited with code 0
[types] src/components/portal.gts:4:49 - error TS2307: Cannot find module './portal-targets.gts' or its corresponding type declarations.
[types]
[types] 4 import { findNearestTarget, type TARGETS } from './portal-targets.gts';
[types] ~~~~~~~~~~~~~~~~~~~~~~
[types]
Note that gts
extensions were used in the import path to avoid needing @rollup/plugin-node-resolve
We already have:
allowImportingTsExtensions: true
```,
so I guess I'd expect it to also work for `gts` extensions?
simonihmig commented
I wonder why this is not failing CI for us?
We run linting on the typescript scenario here, and the fixtures have this .gts import, so shouldn't that have failed Glint and thus the linting script?
NullVoxPopuli commented
lint:fix doesn' run glint. I suspect if we run lint after lint:fix, we'll have errors
simonihmig commented
Also this probably? #196
NullVoxPopuli commented
yup
simonihmig commented
NullVoxPopuli commented
this issue is resolved now, but we now have: #215