embroider-build/addon-blueprint

New addon v2 creates in `test-app` file `ember-cli-update.json` with option `--ci-provider=travis`

Closed this issue · 1 comments

mkszepp commented

While creating a new ember addon V2 i have seen, that in blueprint there was added travis.

Travis CI is was deprecated in v5 see https://deprecations.emberjs.com/ember-cli/v5.x/#toc_travis-ci-support

Steps to reproduce:

  1. ember addon my-addon -b @embroider/addon-blueprint --pnpm
  2. open ´ember-cli-update.json->--ci-provider=travis` is present

Maybe this lines are doing that...

addon-blueprint/index.js

Lines 178 to 196 in eef3557

const appOptions = {
...withoutAddonOptions(options),
target: testAppPath,
skipNpm: true,
skipGit: true,
entity: { name: testAppInfo.name.raw },
name: testAppInfo.name.raw,
rawName: testAppInfo.name.raw,
ciProvider: 'travis', // we will delete this anyway below, as the CI config goes into the root folder
welcome: false,
};
await appBlueprint.install(appOptions);
await Promise.all([
this.updateTestAppPackageJson(path.join(testAppPath, 'package.json'), isPnpm(options)),
this.overrideTestAppFiles(testAppPath, path.join(options.target, 'test-app-overrides')),
fs.unlink(path.join(testAppPath, '.travis.yml')),
]);

Output of addon generate:

installing addon-blueprint
  create .editorconfig
  create .github/workflows/ci.yml
  create .github/workflows/push-dist.yml
  create .prettierignore
  create .prettierrc.cjs
  create CONTRIBUTING.md
  create LICENSE.md
  create README.md
  create my-addon/.eslintignore
  create my-addon/.eslintrc.cjs
  create my-addon/.prettierignore
  create my-addon/.prettierrc.cjs
  create my-addon/.template-lintrc.cjs
  create my-addon/addon-main.cjs
  create my-addon/babel.config.json
  create my-addon/.gitignore
  create my-addon/package.json
  create my-addon/rollup.config.mjs
  create my-addon/src/index.js
  create config/ember-cli-update.json
  create .gitignore
  create package.json
  create test-app-overrides/config/ember-try.js
  create test-app-overrides/ember-cli-build.js
installing app
Ember CLI v5.8.1

✨  Creating a new Ember app in /home/user/projects/my-addon:
  create .editorconfig
  create .ember-cli
  create .eslintignore
  create .eslintrc.js
  create .prettierignore
  create .prettierrc.js
  create .stylelintignore
  create .stylelintrc.js
  create .template-lintrc.js
  create .travis.yml
  create .watchmanconfig
  create README.md
  create app/app.js
  create app/components/.gitkeep
  create app/controllers/.gitkeep
  create app/helpers/.gitkeep
  create app/index.html
  create app/models/.gitkeep
  create app/router.js
  create app/routes/.gitkeep
  create app/styles/app.css
  create app/templates/application.hbs
  create config/ember-cli-update.json
  create config/environment.js
  create config/optional-features.json
  create config/targets.js
  create ember-cli-build.js
  create .gitignore
  create package.json
  create public/robots.txt
  create testem.js
  create tests/helpers/index.js
  create tests/index.html
  create tests/integration/.gitkeep
  create tests/test-helper.js
  create tests/unit/.gitkeep

🚧  Installing packages... This might take a couple of minutes.
pnpm: Installed dependencies

🎥  Initializing git repository.
Git: successfully initialized.

🎉  Successfully created project my-addon.
👉  Get started by typing:

  $ cd my-addon
  $ pnpm start

Happy coding!
NullVoxPopuli commented

hm, seems goofy -- we should probably set ci-provider to none.
would you be willing to submit a PR trying that?

  • 👍1