Option to add custom character vocabulary

[ashwath98]

I think that it will be useful to have an additional parameter where the user can add their own character set for the model.

I think this can be done with some changes to the data_gen code to take characters from a file, and a custom_vocab parameter.

Do you think I should go ahead with implementing this?

[emedvedev]

Of course! I’ll gladly accept a PR. If you look into closed issues, we did have people training with non-standard charsets, and they still might have code patches left.

…

On Jan 4, 2020, 09:06 +0100, Ashwath Shetty ***@***.***>, wrote: I think that it will be useful to have an additional parameter where the user can add their own character set for the model. I think this can be done with some changes to the data_gen code to take characters from a file, and a custom_vocab parameter. Do you think I should go ahead with implementing this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[ashwath98]

Great!! Thanks