normdist2plane potential implementation error?
yangshengaa opened this issue · 0 comments
yangshengaa commented
Hi! It looks like when norm=True
, normdist2plane
is multiplied by the incorrect term?
In normdist2plane
, there is a line
a_norm = a.norm(dim=dim, keepdim=keepdim, p=2).clamp_min(MIN_NORM)
this is the euclidean norm
and subsequently, when norm=True
,
res = res * a_norm
However, res
, I believe, should be multiplied by the Riemannian norm. From equation 24 in Hyperbolic Neural Network, the distance is computed by
And a_norm
in the multiplication.
Please correct me if I am wrong. I appreciate your help in advance.