emirica/twamp-protocol

server.c:253 - gettimeofday: no check of return value

Closed this issue · 0 comments

There is no check to see if the shutdown time has been properly initialized.

Subsequent calls to get_actual_shutdown() use this value and add a timeout for determining whether to close client sockets.

If the client's shutdown value is not properly initialized, server may never clean up those clients.

Same for server.c:523 - unchecked initialization of current time. This may result in closing clients unexpectedly.