emmabostian/fem-design-systems

Close Icon gives a11y warning

Closed this issue · 2 comments

mtliendo commented

When looking at the accessability tab for the modal stories, there is a a11y violation regarding a button. Since the Primary,Secondary, and Tertiary buttons aren't throwing errors, my hunch is that it's the close icon--which is an SVG but behaves like a button.

image

Because this is made with styled components, I don't know the recommended fix (sorry!) 😅

As far as I know, this could be intended as a discussion point in the workshop, but I just wanted to point it out and may have to just head to the workshop for the solution 😉

emmabostian commented

Oh yes I forgot the aria thank you!

  • 👍1
emmabostian commented

I removed as much inline SVG as I could and added appropriate ARIA! Thanks!