Infinite recursion in AbstractNLPDecoder.createTSVReader()
Closed this issue · 2 comments
I will shortly provide a PR that includes a test case and a fix for an infinite recursion in this method.
Just merged your change. I'm going to take off the dependency to the english models from the NLP4J pom.xml though. This was left out intentionally for those who wanted to use NLP4J just for the APIs. Thanks for the bugfix!
The dep is scope test, so it doesn't have any effect at runtime to people
who just want to use the API.
To take out the dep, you have to find another way to fire up the class to
run the test case. I'll be interested to see how you do it, perhaps it's
possible to make a more minimal configuration XML file than I realized.
On Wed, Jul 13, 2016 at 10:03 AM, Jinho D. Choi notifications@github.com
wrote:
Just merged your change. I'm going to take off the dependency to the
english models from the NLP4J pom.xml though. This was left out
intentionally for those who wanted to use NLP4J just for the APIs. Thanks
for the bugfix!—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
emorynlp/nlp4j#28 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ADM9z-qBZ8tDF_X6LDNELpHdunjxQU5Mks5qVPA2gaJpZM4JKuY1
.