emqx/emqx-operator

Need a method to setting private image registry for emqx-operator-reloader image

wooonderful opened this issue · 5 comments

Describe the solution you'd like
We install emqx-operator by helm or yaml, but both have no method to setting the private registry for emqx-operator-reloader image.

Describe alternatives you've considered
the emqx-operator-reloader image's registry should be same to emqx-operator-controller's registry.

the emqx-operator-reloader image's registry should be same to emqx-operator-controller's registry.

Hi, @wooonderful, I think the emqx-operator-reloader image's registry should can be user-defined in EMQX CR File, this has nothing to do with emqx-operator-controller, what do you think ?

the emqx-operator-reloader image's registry should be same to emqx-operator-controller's registry.

Hi, @wooonderful, I think the emqx-operator-reloader image's registry should can be user-defined in EMQX CR File, this has nothing to do with emqx-operator-controller, what do you think ?

image

thanks for your reply, now the helm value.yaml file has repository field, I think this field should be the private registry url, eg: "https://hub-mirror.c.163.com", "https://dockerhub.azk8s.cn", "127.0.0.1:5000"

Image: ReloaderContainerImage,

这里写死了ReloaderContainerImage,应该提供一个instance.getReloaderImage的方法,让用户自定义reloader image地址。

现在的临时方案就是在operator生成statefulset之后,把statefulset的reloader image给patch掉。

Image: ReloaderContainerImage,

这里写死了ReloaderContainerImage,应该提供一个instance.getReloaderImage的方法,让用户自定义reloader image地址。
现在的临时方案就是在operator生成statefulset之后,把statefulset的reloader image给patch掉。

Patching statefulset does not solve this problem, as EMQX Reconsile will modify statefulset back

EMQX Operator 1.2.8 and EMQX Operator 2.0.2 already support this