endail/hx711

Makefile Changes

pbrena opened this issue · 4 comments

pbrena commented

Hello,

I'm currently writing a Gentoo ebuild file (with a lot of help from maintainers) in order to install your Library using the Distribution's canonic methods.

While doing so I've been pointed out a couple of details in the Makefile subject to improvement that I submit to your consideration:

a) There's advice against the use of ldconfig as it causes problems in restricted environments. See for example this reported issue

b) Currently compilation do not support parallelism (make -jN for values of N greater than 1) which is a common practice in the distribution as it is often intensive in compilation tasks. It causes a so called "racing conflict”: using the flag -lhx711 compiling some sources before it is actually available.

Regards
Pablo

endail commented

Hi,

Just to be clear, you would like me to remove ldconfig from the Makefile?

pbrena commented

Yes, it breaks some restricted environments such as Gentoo’s sandbox

endail commented

This is fixed now. I've replaced it with a message to manually invoke ldconfig.

Out of interest, did you have the same problem with lgpio as well? The Makefile uses ldconfig too.

pbrena commented