Show and hide user gist
Closed this issue · 12 comments
On user gist page show and hide gist by clicking gist link
Yes @enderahmetyurt I have planned, already started with that I think by tomorrow I should be able to do that. My assumption is to just get the gist content and display in the content section on click of list view.
Yes. You can do it with your assumption. I want to show an example of what I really want. https://getbootstrap.com/docs/4.0/components/collapse/ When the user clicks the gist name on the list and open a div which includes gist codes and then click again the link div should be close.
@enderahmetyurt 👍 we thought same thing I planned it this way https://getbootstrap.com/docs/4.0/components/list-group/#javascript-behavior
No. I guess we should do toggle below the gist link. Because opening it left of the link cannot be fit in a div or it should be smaller. Can you do it as I mentioned?
On I forgot to mention I am taking the approach of list_group but I am doing it below the List item, not on right @enderahmetyurt
which is same as your example difference is I am not using accordion
@enderahmetyurt I have completed implementation of show/hide. Attached is the screenshot. Only thing which I have some issue is with the Content displaying as it comes in gist editor because every file is of different format e.g .rb, .md
I tried Redcarpet Markdown and Rouge syntax highlighter, but markdown changes it to HTML which is not case with all the gist. I explored Rouge but need to see if we can do that based on just file extension with Rouge. But for now I am committing changes. Let me know your thought
Thank you @shivanibhanwal but it's not working properly.
I want to make some color with Redcarpet. Gist API gives the extension of the gist. It doesn't make any sense with raw html.
@enderahmetyurt Markdown redcarpet will not help with syntax highlitghter only that case be changed. I need to explore that more.
Okay. Could you fix the accordion problem?
Hi, @enderahmetyurt I have fixed it completely will be raising PR in a few minutes. It has many cases to handle. The accordion issue was because one gist can have Many Files in it. So I have handled it too
Great. It looks nice @shivanibhanwal I will be check later. Thanks 🙏
@enderahmetyurt it is complete now you can check the changes and let me know.