enesozturk/rn-swipeable-panel

1.1.0 Breaks

Closed this issue ยท 8 comments

Version 1.1.0 removed the component folder from the node modules and doesn't build, and the last version that works is Version 1.0.28. Just wanted to let you know!

Hey @monkeyank, Thanks for using rn-swipeable-panel and notify this issue to me. Version 1.0.1 has many bugs. Thats way it is better to use newest version as you do. :)

Yesterday I released new version 1.1.0 that has Typescript support. Type definition will be added to DefinitelyTyped as well. #45519. Have good coding ๐Ÿ™Œ๐Ÿฝ

a613 commented

1.1.0 also is broken because index.js looks for ./components/Panel but that doesn't exist (components is inside a lib directory).

I confirmed that 1.0.28 works! Thank you, @monkeyank

FYI @enesozturk I looked at your example project, and it imports rn-swipeable-panel using a relative path, which isn't how other devs import it: https://github.com/enesozturk/rn-swipeable-panel/blob/master/examples/App.tsx#L24

Hi @a613, thanks for let me know. I will try to fix that issue as soon as possible.

How do you suggest to import Panel component in example? Can you share any example for that? I would like to make it proper way. ๐Ÿค”

a613 commented

I'm not sure where the lib directory is introduced, but it's new for sure:

1.0.28:
Screen Shot 2020-06-19 at 10 25 21 AM

1.1.0:
Screen Shot 2020-06-19 at 10 31 10 AM

howcome this has not been hotfixed yet?

Hi, This issue has not been fixed yet. I'm having very busy days right now. I will check and fix the issue as soon as I can. Any PR's may be accepted by the way.

Version 1.0.29 works for me while 1.1.0 does not.

Hi guys, version 1.1.0 had some breaks, I published new version. You can try rn-swipeable-panel@1.2.0.