entropyxyz/synedrion

Derive `BaseRound::NEXT_ROUND_NUM` automatically

Closed this issue · 2 comments

fjarri commented

Theoretically, we can calculate BaseRound::NEXT_ROUND_NUM based on BaseRound::ROUND_NUM and whether the round implements FinalizableToResult (then it's None) or FinalizableToNextRound (then it's BaseRound::ROUND_NUM + 1).

fjarri commented

Actually: do we even need ROUND_NUM/NEXT_ROUND_NUM at all at the typed level? The round number is not used anywhere, and if Session needs it, it can just as well count the rounds itself.

Invalidated by the more dynamic nature of manul (where there actually can be several possible rounds following the finalization).