New warnings when running specs calling zxcvbn-ruby with latest Rake version
grempe opened this issue · 7 comments
The following warnings are now thrown from including zxcvbn in the test suite of my ruby gem. These just started showing up with the update of Rake from v10.5.0 to v11.1.2
$ bundle exec rake
/usr/local/var/rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/zxcvbn-ruby-0.1.1/lib/zxcvbn/matchers/l33t.rb:34: warning: shadowing outer local variable - substitution
/usr/local/var/rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/zxcvbn-ruby-0.1.1/lib/zxcvbn/entropy.rb:132: warning: `-' after local variable or literal is interpreted as binary operator
/usr/local/var/rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/zxcvbn-ruby-0.1.1/lib/zxcvbn/entropy.rb:132: warning: even though it seems like unary operator
...
I am not able to take that on right now. Sorry.
On May 30, 2016, 17:53 -0700, Trung Lênotifications@github.com, wrote:
@grempe(https://github.com/grempe)thanks for the report. Would you be able to submit a PR?
—
You are receiving this because you were mentioned.
Reply to this email directly,view it on GitHub(#19 (comment)), ormute the thread(https://github.com/notifications/unsubscribe/AAAAdejSmXhHP9KipgMNTCJ-j1Z7-89Oks5qG4ajgaJpZM4ITdWI).
@stevehodgkiss thanks for merging #20
When can we expect this to land on RubyGems ?
@johnsyweb Can we update RubyGems with the latest version? v0.1.2?
Thanks for notifying me. I'll do this today.
https://rubygems.org/gems/zxcvbn-ruby/versions/0.1.2 has been published. Thanks for the fix, @detj.