envelope-zero/backend

Transaction filtering by direction and type

morremeyer opened this issue · 0 comments

Transaction filtering

The transaction filtering we have in place currently is incomplete and wrong since it tries to enable both filtering by the direction of the transaction, considering if the involved accounts are internal or external as well as the type of the transaction, considering the effects on the buyget.

I thought about this for a while and arrived at the conclusion that we'll need two different filters, one direction filter and one type filter.

direction: purely for internal/external account considerations

Has the following filter values

  • in: Transaction from an external to an internal account
  • out: Transaction from an internal account to an external account
  • internal: Transaction from an internal to an internal account

type: For the effect a transaction has on the budget

Has the following filter values

  • income: From an off-budget to an on-budget account
  • spend: From an on-budget to an off-budget account
  • transfer: From an on-budget to an on-budget account

I'm not yet happy with incoming and income being named this similarly. Any suggestions to improve this are very welcome. Edit: Updated direction incoming and outgoing to in and out, this makes it much harder to confuse.