eopb/cargo-override

Escape paths when adding them to toml

Closed this issue · 2 comments

eopb commented

Problem

This code can panic

todo!("We haven't escaped anything, so we can't be sure this will parse")

Shouldn't the correct approach be to create the tables natively in toml_edit, rather than generating it and then parsing it?

eopb commented

Yup, that's the plan. I was just struggling to get the exact formatting that I was after when I first tried this, but I expect it's very much doable