[854567] [synergy] synergyc fails to start on ARM(possibly other platforms too.)
Closed this issue · 4 comments
BTS_msg_id: 20170208113523.GF2696@narnia.kingsly.net
BTS author: Kingsly John member+debian@kingsly.net
Package: synergy
Version: 1.4.16-1.2
Severity: important
Dear Maintainer,
Synergy client(synergyc) shipped by Debian fails to start on both Jessie and
Stretch for me on my ARM-based chromebook.
Multiple reports from other Debian ARM users submitted upstream.
https://github.com/symless/synergy/issues/5504
https://github.com/symless/synergy/issues/5504
Issue may not limited to ARM though, upstream resolution is in this bug
report which doesn't menion arch.
https://github.com/symless/synergy/issues/5068
Bug is triggered when XQueryBestCursor returns 0 for both width and height.
There is a fix upstream but only for a recent version of synergy.
The filenames seem to have been changed in recent releases so I made the
appropriate changes to this file in the debian sources.
--- synergy-1.4.16.orig/src/lib/platform/CXWindowsScreen.cpp
+++ synergy-1.4.16/src/lib/platform/CXWindowsScreen.cpp
@@ -33,6 +33,7 @@
#include "TMethodEventJob.h"
#include
#include
+#include
#if X_DISPLAY_MISSING
error X11 is required to build synergy
#else
@@ -1660,8 +1661,10 @@ CXWindowsScreen::createBlankCursor() con
// this seems just a bit more complicated than really necessary
// get the closet cursor size to 1x1
-
unsigned int w, h;
-
unsigned int w = 0, h = 0; XQueryBestCursor(m_display, m_root, 1, 1, &w, &h); -
w = std::max(1u, w); -
h = std::max(1u, h); // make bitmap data for cursor of closet size. since the cursor // is blank we can use the same bitmap for shape and mask: all
I have created and tested a custom package with the above patch on
Stretch and can confirm that it works fine.
I was originally on Jessie when I encountered the bug, but since I had
a bunch of packages from Stretch installed on my system, decided to do a
dist-upgrade to eliminate the chance of my system alone being broken.
Found that synergyc failed in the same way after upgrading to Stretch
too.
So the patch needs to be applied to both 1.4.16-1 in Jessie and
1.4.16-1.2 in Stretch (I haven't tested on Jessie.)
- What led up to the situation?
Tried to use synergy client to share my keyboard and mouse.
- What exactly did you do (or not do) that was effective (or
ineffective)?
Ran synergyc re.mo.te.ip
- What was the outcome of this action?
Client exited immediately without connecting to remote server.
- What outcome did you expect instead?
Client should have connected to the remote server
-- System Information:
Debian Release: 9.0
APT prefers testing
APT policy: (500, 'testing')
Architecture: armhf (armv7l)
Kernel: Linux 3.14.0 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages synergy depends on:
ii libc6 2.24-9
ii libcrypto++6 5.6.4-6
ii libcurl3 7.52.1-2
ii libgcc1 1:6.3.0-5
ii libice6 2:1.0.9-1+b1
ii libqt4-network 4:4.8.7+dfsg-11
ii libqtcore4 4:4.8.7+dfsg-11
ii libqtgui4 4:4.8.7+dfsg-11
ii libsm6 2:1.2.2-1+b1
ii libstdc++6 6.3.0-5
ii libx11-6 2:1.6.4-3
ii libxext6 2:1.3.3-1
ii libxi6 2:1.7.9-1
ii libxinerama1 2:1.1.3-1+b1
ii libxrandr2 2:1.5.1-1
ii libxtst6 2:1.2.3-1
synergy recommends no packages.
synergy suggests no packages.
-- no debconf information
--
BTS_msg_id: 20170208115554.GG2696@narnia.kingsly.net
BTS author: Kingsly John member+debian@kingsly.net
Sorry, pasted the same bug report twice in the original submission.
Here are the 2 bug reports submitted upstream for the same version shipped by
Debian.
https://github.com/symless/synergy/issues/5504 (Debian)
and
https://github.com/symless/synergy/issues/5322 (2 reports from Debian/debian based
distros.)
--
BTS_msg_id: E1cdd0I-000CZx-8H@fasolo.debian.org
BTS author: Joshua Honeycutt joshua.honeycutt@gmail.com
Source: synergy
Source-Version: 1.4.16-2
We believe that the bug you reported is fixed in the latest version of
synergy, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 854567@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Joshua Honeycutt joshua.honeycutt@gmail.com (supplier of updated synergy package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 08 Feb 2017 16:08:21 -0600
Source: synergy
Binary: synergy
Architecture: source
Version: 1.4.16-2
Distribution: unstable
Urgency: medium
Maintainer: Joshua Honeycutt joshua.honeycutt@gmail.com
Changed-By: Joshua Honeycutt joshua.honeycutt@gmail.com
Description:
synergy - Share mouse, keyboard and clipboard over the network
Closes: 854567
Changes:
synergy (1.4.16-2) unstable; urgency=medium
.
- Added ensure_non00_cursor.patch to fix a crash when synergyc starts.
Closes: #854567 - Updated debian/control fields: Maintainer, Homepage, Vcs-* with new
maintainer and upstream information - Changed description to indicate new upstream locations for binary and
source releases (old URL returned page not found)
Checksums-Sha1:
34e5dc941c0a290984659ec910ff8c2b59655975 1989 synergy_1.4.16-2.dsc
ddc533c0fd4ad6e7e8240a1ac50793802dd3bea5 18468 synergy_1.4.16-2.debian.tar.xz
Checksums-Sha256:
80afd7f6e770993a2fbbd78cb64956c092dd88f033b9e4f5f3552c4c9a9af7a2 1989 synergy_1.4.16-2.dsc
1de73f830f4faf262ae1e8a494b8678d1c426b316e2ce2271e98b758b03bba6c 18468 synergy_1.4.16-2.debian.tar.xz
Files:
5963b05a7a051f4033db61b78a15290f 1989 x11 optional synergy_1.4.16-2.dsc
e2187707b2ead6f055e938a43436ff89 18468 x11 optional synergy_1.4.16-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE3ZhhqyPcMzOJLgepaOcTmB0VFfgFAlii/0gACgkQaOcTmB0V
Ffi0mA/+N3djhHWk7qCGcR09c7I3eIiMW/LF4KDZ/+sK5gLA4kzytWdeIWp8GDKv
cvdeSy/AuGVwnPbPY3JL6AK1+jPIzIbQjLNG4z1pAUV9fRq0Xt08+HMRx+TpV3Yh
0bb+ziOoR5FHa5h18xEUcq2pDLkPSUCUp7pgSzakIcu9nvpFSRWHo/Fhi6E/BYDs
A4716o22AjeuXJLXfhL+xpNCIml2ugsUptarl7CoWnvwrbMXdUgU35zg4iqPeHjj
jX3olQOeMQAOR5x02/inddeAX49WTGk9pbNYC75KXzqxgnQVhUeH1Ni7iqOHI/0d
ThTnQZHOgPBMeYXrxmZ5dFFtMSqq/5KehKhC7MtoF7XIp1QSG9AWqesL2Yxj1TId
qcper+gqXjpgxfrwlIjlBkFBk9L3z6oycjQjMJmKB3HkZWVWH34jeLTrqNkq6JLw
X4eRENTNA/d6gJm/6tc4mr5WD7P3Nd8OKf5p0PIgH34tF8jAiWx9QmGiwS9lFj1J
Sc3R2QVbEpokyU6pzOp50Yy8EjiLlkzxC8+qoRxOZdHPlTQf/4CsEi7rJP/VQhI5
+9KGYHIIp3NpcfaBWVFvyfYJkvjHAmjunyp+9gVufCaTJiNpkffWZnAWTV6G7/yb
X6uLAyc8q2i4og4dhVa8+rvnsmRTJBtXDxqVog5FOhLDtMiEfP8=
=mVd2
-----END PGP SIGNATURE-----
BTS_msg_id: CAAgawWX1V-eKpxp==cJC0hzc27KwSBPuPV3k3H9ZqboOX-XspQ@mail.gmail.com
BTS author: Joshua Honeycutt joshua.honeycutt@gmail.com
I have accepted this change and the upload has been made to unstable.
This should hopefully migrate to stretch/testing as the Release team
works through their queue during the freeze. You can see bug #855146
to follow the migration process.
I still intend to follow up with a jessie update through the
stable-proposed-updates channel. I'll provide one more update to this
bug once I've taken action.