epam/ketcher

ketcher-react depends on miew-react v1.0.0 which is 3 years old

Opened this issue · 1 comments

rvaidya commented

Steps to Reproduce

  1. Go to https://github.com/epam/ketcher/blob/master/packages/ketcher-react/package.json
  2. Look at miew-react version

Actual behavior
I get dependency conflict warnings when I try to use React 18.

Expected behavior
No dependency conflicts caused by stale dependencies
miew-react dependency version should be https://www.npmjs.com/package/miew-react/v/0.11.0

Ketcher version [e.g. v2.4.2].
2.25.0

SourceCodeDeleted commented

I might have a problem because of this . It seems that Miew 1.0.0 requires react@"^17.0.2 -- I am on 18 . I noticed it was updating somethings.

Is there a reason for keeping this so low?

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: draft-js-custom-styles@2.1.1
npm WARN Found: draft-js@0.11.7
npm WARN node_modules/draft-js
npm WARN   draft-js@"^0.11.7" from ketcher-react@2.26.0
npm WARN   node_modules/ketcher-react
npm WARN     ketcher-react@"^2.21.0" from the root project
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer draft-js@"0.10.x" from draft-js-custom-styles@2.1.1
npm WARN node_modules/draft-js-custom-styles
npm WARN   draft-js-custom-styles@"^2.1.1" from ketcher-react@2.26.0
npm WARN   node_modules/ketcher-react
npm WARN 
npm WARN Conflicting peer dependency: draft-js@0.10.5
npm WARN node_modules/draft-js
npm WARN   peer draft-js@"0.10.x" from draft-js-custom-styles@2.1.1
npm WARN   node_modules/draft-js-custom-styles
npm WARN     draft-js-custom-styles@"^2.1.1" from ketcher-react@2.26.0
npm WARN     node_modules/ketcher-react
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: miew-react@1.0.0
npm WARN Found: react@18.3.1
npm WARN node_modules/react
npm WARN   react@"^18" from @blocknote/mantine@0.15.9
npm WARN   node_modules/@blocknote/mantine
npm WARN     @blocknote/mantine@"^0.15.9" from the root project
npm WARN   189 more (@blocknote/react, @clerk/clerk-react, @clerk/nextjs, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^17.0.2" from miew-react@1.0.0
npm WARN node_modules/miew-react
npm WARN   miew-react@"^1.0.0" from ketcher-react@2.26.0
npm WARN   node_modules/ketcher-react
npm WARN 
npm WARN Conflicting peer dependency: react@17.0.2
npm WARN node_modules/react
npm WARN   peer react@"^17.0.2" from miew-react@1.0.0
npm WARN   node_modules/miew-react
npm WARN     miew-react@"^1.0.0" from ketcher-react@2.26.0
npm WARN     node_modules/ketcher-react
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: miew-react@1.0.0
npm WARN Found: react-dom@18.3.1
npm WARN node_modules/react-dom
npm WARN   react-dom@"^18" from @blocknote/mantine@0.15.9
npm WARN   node_modules/@blocknote/mantine
npm WARN     @blocknote/mantine@"^0.15.9" from the root project
npm WARN   84 more (@blocknote/react, @clerk/clerk-react, @clerk/nextjs, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react-dom@"^17.0.2" from miew-react@1.0.0
npm WARN node_modules/miew-react
npm WARN   miew-react@"^1.0.0" from ketcher-react@2.26.0
npm WARN   node_modules/ketcher-react
npm WARN 
npm WARN Conflicting peer dependency: react-dom@17.0.2
npm WARN node_modules/react-dom
npm WARN   peer react-dom@"^17.0.2" from miew-react@1.0.0
npm WARN   node_modules/miew-react
npm WARN     miew-react@"^1.0.0" from ketcher-react@2.26.0
npm WARN     node_modules/ketcher-react