Suggestion: Struct Visualizer in Locals tab
tinloaf opened this issue · 10 comments
First: Thanks for seer, it's awesome.
One thing that regularly costs me time is that I have structures in my 'locals' tab that I can't really look at without using the struct visualizer. The code to build a tree-view for structs seems to be there (it's used in the struct visualizer) - would it be possible/desirable to also directly use that in the locals tab? I.e., directly make all structs expandable in the locals tab?
Hi,
First: Thanks for seer, it's awesome.
Thanks!
To clarify, a struct in the "locals" tab currently shows the structure in a flat manner.
And you want it more "nested", as in the Struct Visualizer.
I think this is doable. I'll probably make it an option accessible from the "Locals" tab.
Yes exactly. If would be great if the struct in the 'locals' tab could be expanded in the same way as in the struct visualizer tab. Thanks! :)
This should be implemented in the mainline. Go ahead and pull it and let me know how you like it.
Note. I haven't added the automatic tree expanding/collapsing. I wanted to get the basics down first. Let me know what types of expanding you want. For example:
- I can expand always, then you manually collapse things as you see fit.
- I can expand never, then you manually expand things as you see fit.
- I can expand/collapse things at the level you clock on, and it will apply to all levels below that.
Anyway, you get the idea. Let me know what you think.
Hi, this looks great. Thanks! :) I think that it's okay to leave every symbol unexpanded at the start.
However, I suspect (but I'm not sure) this causes a crash for me. I have created #181 for the crash.
Cool. I'll leave it as unexpanded, for now.
I've checked #181. I think I know what's going on. And it related to my changes.
I noticed the "locals" tab didn't expand structs that were passed by reference. This is fixed in "main".
Also, I've added struct expansion to the "logger" tab. I'll do the same to the "tracker" tab and the "arguments" tab shortly. This will make this feature a little more consistent through out Seer.
The "tracker" tab and "arguments" tab now have nested struct viewing.
"main" has been updated in case you want to try it.
I'll close this task in a few days.
Thanks, I think it's a great improvement!
Good. Thanks.
Closing task.