Config value to disable Epsagon function at service level is not used

Question

Config value to disable Epsagon function at service level is not used

Closed this issue 5 years ago · 5 comments

Setting config value for disable = false at the service level is not respected.
In src/index.js line 99 if (this.config().disable)

This I guess is checking just for the existing of the config attribute and not checking the actual value to equal true so it cannot be used to control whether epsagon is disable or not. We are relying on this config value so we can disable epsagon for specific environment

Perhaps it can be changed to:
if (this.config().disable && this.config().disable === 'true')?

Cheers, Ky

Answer 1 · 2019-04-10T07:29:52.000Z

Hi @ky-cheng - I tried now with the following configuration:

custom:
  epsagon:
    token: your-token-here
    appName: optional-application-name
    disable: false

And I got the functions wrapped successfully.
Can you please give me an input that fails? Please note that the input should be a boolean type and not string.

Thanks

Answer 2 · 2019-04-10T07:32:06.000Z

We can however change it to:
if (this.config().disable && this.config().disable.toString().toLowerCase() === 'true')
Just to support both boolean and string inputs.

Answer 3 · 2019-04-10T07:35:59.000Z

Cool. In our use case we inject the value via AWS system manager parameter store `disable: ${ssm:/epsagon/${opt:env}/disable}' So I am not sure how Serverless framework handle variable injection this way whether it sets it as string or boolean. Let me try with just {opt:variable} to see what that does without involving parameter store. Thanks for looking into this. Cheers, Ky

…

On Wed, 10 Apr 2019 at 17:29, Ran Ribenzaft ***@***.***> wrote: Hi @ky-cheng <https://github.com/ky-cheng> - I tried now with the following configuration: custom: epsagon: token: your-token-here appName: optional-application-name disable: false And I got the functions wrapped succesfully. Can you please give me an input that fails? Please note that the input should be boolean type and not text. Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#45 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AgWOhXfNcpqHkhkazr9kBftpi8Ip8rguks5vfZLwgaJpZM4ckEBI> .

Answer 4 · 2019-04-11T05:05:06.000Z

@ranrib thanks for the quick fix! So I have verified that injecting value are always injected as string hence the boolean check does not work.

Eg. disable: ${opt:disableEpsagon} injecting via cli parameters or
disable: ${ssm:/epsagon/${opt:env}/disable} injecting via aws system manager parameter store both are string value

I got around the issue by doing the following:

  disableEpsagon:
    local: true
    other: false
  epsagon:
    token: ${ssm:/epsagon/token~true}
    appName: ${opt:env} Inquisitive
    disable: ${self:custom.disableEpsagon.${opt:env}, self:custom.disableEpsagon.other}

which sets disable to true or false base on env

Answer 5 · 2019-04-11T05:16:38.000Z

🎉 This issue has been resolved in version 1.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀